[8.0.0] Move Apple multi arch linking support out of the bazel binary #24273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… linking_support.bzl (both from builtins_bzl/common/objc/) via apple_common. This is inpreparation for moving the content of both bzl files to the repo in unknown commit. PiperOrigin-RevId: 686100272 Change-Id: Iadbe8da6a4335e30daca889cd19afcb627df2b5c
PiperOrigin-RevId: 689003624 Change-Id: I0826d0ddea18b6c4b21e009d93c4de46389031ad
…h_binary_support.bzl and the related providers after their move to rules_apple. PiperOrigin-RevId: 694055059 Change-Id: Ica3f756f7ec10869cbc7cd475c8d0d962fe7d274
github-actions
bot
added
the
awaiting-review
iancha1992
changed the title
|
@pzembrod one of the tests is failing. FYI. |
|
The Windows failure was unrelated but due to recent CI upgrade, fixed at #24269 I rebased this PR and the presubmit should pass now. |
meteorcloudy
approved these changes
Nov 14, 2024
Merged
via the queue into
bazelbuild:release-8.0.0
with commit Nov 14, 2024
c877f8a
45 checks passed
github-actions
bot
removed
the
awaiting-review
|
FYI @keith @brentleyjones This change will break rules_apple: |
|
blocked on #24582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove internal functions for Apple multi arch linking from apple_common and instead expose functions needed by multi arch linking functions in the repo.